[PATCH] D75528: [yaml2obj][obj2yaml][test] - Add base tests for relocation addends.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 03:03:07 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/relocation-addend.yaml:83
+
+## Check that obj2yaml omits zero addends.
+# RUN: yaml2obj --docnum=2 %s -o %t11 -D ADDEND=0
----------------
jhenderson wrote:
> I'm not sure we need a 32-bit case for this one, as the behaviour is independent of the bitness.
Yeah, that is why I have no 64-bit case at all. To improve,
I've changed this test to be "Case 3" and made it use the first YAML document.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75528/new/

https://reviews.llvm.org/D75528





More information about the llvm-commits mailing list