[PATCH] D75883: Add Builder::getI64VectorAttr.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 21:55:29 PDT 2020


bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/IR/Builders.cpp:109
+DenseIntElementsAttr Builder::getI64VectorAttr(ArrayRef<int64_t> values) {
+  return DenseElementsAttr::get(
+             VectorType::get(static_cast<int64_t>(values.size()),
----------------
AFAIR, you can just do ```DenseIntElementsAttr::get``` - you don't need the trailing cast. The method right above can also be fixed the same way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75883/new/

https://reviews.llvm.org/D75883





More information about the llvm-commits mailing list