[PATCH] D75836: [MC] Allow Stackmap sections after DWARF in MachO.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Ok. I'm going to land this to unblock people who are hitting this assertion.

Adrian: I think your suggestion was to switch to the stackmap section early, since it is only switching late that triggers this assertion? I didn't end up digging too far into this option because the StackMaps instances are hidden members of the target-specific AsmPrinter subclasses: At the moment there's no way to know whether a stackmap section will be needed in the generic AsmPrinter code.

If emitting or switching to the stackmap section is the right thing to do then I could add an AsmPrinter hook for that.

Alternatively, if switching to a section that is ultimately unused is safe, I could just unconditionally switch to the stackmap section early in the AsmPrinter.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75836/new/

https://reviews.llvm.org/D75836