[PATCH] D75874: [mlir][spirv] Use SmallVector<ArrayRef> for availability queries

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 14:35:37 PDT 2020


antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a child revision: D75875: [mlir][spirv] Support querying type extension/capability requirements.

Previously extensions and capabilities requirements are returned as
SmallVector<SmallVector>. It's an anti-pattern; this commit improves
a bit by returning as SmallVector<ArrayRef>. This is possible because
the internal sequence is always known statically (from the spec)
so that we can use a static constant array for it and get an ArrayRef.

Depends On D75872 <https://reviews.llvm.org/D75872>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75874

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVAvailability.td
  mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
  mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75874.249217.patch
Type: text/x-patch
Size: 10515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200309/2aa887f7/attachment-0001.bin>


More information about the llvm-commits mailing list