[PATCH] D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Support/raw_ostream.cpp:795
   // the complexity.
-  if (S_ISCHR(statbuf.st_mode) && isatty(FD))
+  if (S_ISCHR(statbuf.st_mode) && sys::Process::FileDescriptorIsDisplayed(FD))
     return 0;
----------------
ychen wrote:
> Why not just use `raw_fd_ostream::is_displayed()` ?
`raw_fd_ostream::is_displayed` -> `is_displayed`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75278/new/

https://reviews.llvm.org/D75278