[PATCH] D75775: [mlir][Vector] Add a vector.matrix_multiply op on 1-D vectors

[Aart Bik via Phabricator via llvm-commits]

aartbik accepted this revision.
aartbik added inline comments.


================
Comment at: mlir/include/mlir/Conversion/VectorToLLVM/ConvertVectorToLLVM.h:20
+/// Intrinsics. To lower to assembly, the LLVM flag -lower-matrix-intrinsics
+/// will be needed wheninvoking LLVM.
+void populateVectorToLLVMMatrixConversionPatterns(
----------------
typo: wheninvoking -> when invoking


================
Comment at: mlir/include/mlir/IR/OpBase.td:490
+// `allowedRanks` list
+class IsVectorOfRankPred<list<int> allowedRanks> :
+  And<[IsVectorTypePred,
----------------
rebase this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75775/new/

https://reviews.llvm.org/D75775