[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions

[Hideto Ueno via Phabricator via llvm-commits]

uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2429
+  // unbounded cycle.
+  // We use scc_iterator which uses Tarjan algorithm to find all the maximal
+  // SCCs. Those are SCCs which are as big as they can get. i.e. in which you
----------------
nit: Normally, the word "strongly connected components" contains its maximality. So I think it's more concise to omit the description for maximality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691