[PATCH] D74819: [DebugInfo] Report unsupported maximum_operations_per_instruction values

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:511
+DWARFDebugLine::ParsingState::ParsingState(
+    struct LineTable *LT, uint64_t TableOffset,
+    function_ref<void(Error)> ErrorHandler)
----------------
MaskRay wrote:
> `struct` can be omitted (and conventional in C++).
I took a look at this, but `LineTable` is both a member name and struct name here. We'd have to explicitly qualify the type name to be `DWARFDebugLine::LineTable`. There are several similar maybe unnecessary `struct` specifiers in the header too, but these are all because various members have the same name as their type. I'd recommend leaving this until the variable case changes are made in this code, after which there should be no ambiguity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74819/new/

https://reviews.llvm.org/D74819