[PATCH] D75821: [PowerPC] Remove the repeated definition for some InstAlias for mtspr/mfspr

Mon Mar 9 07:30:43 PDT 2020

ZhangKang added a comment.

In D75821#1912110 <https://reviews.llvm.org/D75821#1912110>, @nemanjai wrote:

> This is a curious situation. How did we end up having multiple definitions of instruction aliases?

These were added six years ago in different time. The code is added from different patch. The one is https://reviews.llvm.org/rG62cb635 `Implement asm support for a few PowerPC bookIII that are needed for assembling` in 2013.9, and the other is https://reviews.llvm.org/rGb1ccf56 `Add a number of aliases for SPR access in 2014.7`.

Before my NFC patch https://reviews.llvm.org/rGb0f3d49a05ce487650ac0b3e3a23eae21f494a96 , the alias definition for MTSPR/MFSPR is unordered. The second author added the repeated code whether search whether there is the same definition.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75821/new/

https://reviews.llvm.org/D75821