[PATCH] D72416: [Flang] add flang as a new subproject in cmake

[David Truby via Phabricator via llvm-commits]

DavidTruby requested changes to this revision.
DavidTruby added a comment.
This revision now requires changes to proceed.

This doesn't seem to be sufficient to build Flang for me. My process was as follows:

  git clone https://github.com/llvm/llvm-project
  cd llvm-project
  arc patch D72416
  git clone https://github.com/pmccormick/f18 flang # The f18 branch with LLVM cmake infrastructure changes
  mkdir build && cd build
  cmake -GNinja -DLLVM_ENABLE_PROJECTS="mlir;flang" ../llvm
  ninja

after which I get a correct build of llvm with no errors in the cmake step, but the flang binaries are not present.
My cursory reading of the cmake files suggests to me that we _do_ need flang in LLVM_ALL_PROJECTS, as it seems that LLVM_ENABLE_PROJECTS only affects things that are in LLVM_ALL_PROJECTS. If I add flang to LLVM_ALL_PROJECTS and run the above commands I get a correct in-tree build of flang.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72416/new/

https://reviews.llvm.org/D72416