[PATCH] D75837: Introduce std.execute_region op

Mon Mar 9 05:20:35 PDT 2020

nicolasvasilache added inline comments.

================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:981
+      The execute_region operation executes the region held exactly once. The op
+      cannot have any operands, nor does its region have any arguments. All SSA
+      values that dominate the op can be accessed inside. The op's region can
----------------
I'll repaste my comment that I don't believe was addressed:

```
To be generally useful for Linalg and other ops with regions that refuse to introduce SSA values prematurely (I.e. that use type information to encode the semantics and delay SSA value creation until inlining) you need both arguments and capture.
Can this be designed and implemented so it serves today’s needs that are already more general than “just capture”?
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837