[PATCH] D75796: [llvm-objdump][test] Reorganize ELF --syms tests

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

You should probably extend the test case to enumerate the possible section types supported by LLVM + 1 other unknown value. Similarly, an unknown binding value might be good to test. Testing more section index values might be wise too, i.e. values >= SHN_LORESERVE that don't correspond to a special value, and SHN_XINDEX, where the real section index is stored elsewhere.

What does llvm-objdump do if you specify an invalid section index? That should be tested too, I guess. Ditto an invalid name?

Finally, what about non-zero st_other values? Does llvm-objdump print those at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75796/new/

https://reviews.llvm.org/D75796