[PATCH] D75834: [NFC][PowerPC] Simplify the logic in lower select_cc

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 01:34:49 PDT 2020


ZhangKang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7543-7547
   // We might be able to do better than this under some circumstances, but in
   // general, fsel-based lowering of select is a finite-math-only optimization.
   // For more information, see section F.3 of the 2.06 ISA specification.
   // With ISA 3.0, we have xsmaxcdp/xsmincdp which are OK to emit even in the
   // presence of infinities.
----------------
Above  comments should be splitted into 2 parts
One is below, it should before the line 7569.
```
// We might be able to do better than this under some circumstances, but in
  // general, fsel-based lowering of select is a finite-math-only optimization.
  // For more information, see section F.3 of the 2.06 ISA specification.
```

The other is below, it should before the line 7556.
```
// With ISA 3.0, we have xsmaxcdp/xsmincdp which are OK to emit even in the
  // presence of infinities.
```

You patch is similar without the patch https://reviews.llvm.org/D62993 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75834/new/

https://reviews.llvm.org/D75834





More information about the llvm-commits mailing list