[PATCH] D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 8 21:51:53 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/unknown-arch-attr.test:44
+# The content is the encoding of the arch feature "rv32i2p0_x1p0_m2p0"
+    Content: 412300000072697363760001190000000572763332693270305F783170305F6D32703000
----------------
`unittests/Support/RISCVAttributeParser.cpp` is more suitable for such tests. See `unittests/Support/ARMAttributeParser.cpp` for examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75833/new/

https://reviews.llvm.org/D75833





More information about the llvm-commits mailing list