[PATCH] D75832: [MLIR] Change custom printer/parser for loop.parallel and loop.reduce.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:418
 
   // Parse step value.
   SmallVector<OpAsmParser::OperandType, 4> initVals;
----------------
Fix the comment while you're at it?


================
Comment at: mlir/test/Dialect/Loops/ops.mlir:64
+    %red = loop.parallel (%i2) = (%min) to (%max) step (%i1)
+                                        init (%zero) -> f32 {
       %one = constant 1.0 : f32
----------------
It'd be nice if we could have one test with more than one reduction (with two different types ideally).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75832/new/

https://reviews.llvm.org/D75832