[PATCH] D75808: [ValueTracking] isKnownNonZero, computeKnownBits for freeze

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:580
                                         const Instruction *CtxI = nullptr,
                                         const DominatorTree *DT = nullptr);
 
----------------
We should consider having 3 API functions now. isUndef, isPoison, isUndefOrPoison, with a common impl that takes two booleans. It makes it clearer at the call sites (IMHO).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75808/new/

https://reviews.llvm.org/D75808