[PATCH] D75828: [AssumeBundles] filter usefull attriutes to preserve

[Tyker via Phabricator via llvm-commits]

Tyker marked an inline comment as done.
Tyker added inline comments.


================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:109
+  }
+}
+
----------------
jdoerfert wrote:
> Are we sure we want to keep a positive list of useful ones? (Instead of a negative list of not-useful ones?)
i looked at all attributes we support and most of them aren't useful. so i think the list is shorter this way and will need less updating.

but perhaps a negative pattern has a better default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75828/new/

https://reviews.llvm.org/D75828