[PATCH] D75799: [JumpThreading] Don't create PHI nodes with "is.constant" values

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D75799#1911583 <https://reviews.llvm.org/D75799#1911583>, @void wrote:

> In D75799#1911541 <https://reviews.llvm.org/D75799#1911541>, @lebedev.ri wrote:
>
> > Doesn't fixing that instead sounds like more general fix rather than this?
>
>
> What do you mean by "that"? This *does* fix the issue. Unless you can see another issue that I can't.


Previous comment implies there are DCE failures being exposed by this:

In D75799#1911489 <https://reviews.llvm.org/D75799#1911489>, @void wrote:

> and the `__bad_copy_from` isn't being DCE'd as it should be.


I'm wondering why we should be papering over those DCE deficiencies
by trying to avoid performing folds that end up exposing them
instead of fixing DCE deficiencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75799/new/

https://reviews.llvm.org/D75799