[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:89
+      if (Context.getMaxVersion() >= 5) {
+        Expected<bool> Status = M->Header.parseMacroHeader(data, &Offset);
+        if (!Status) {
----------------
ikudrin wrote:
> It looks like you do not initialize the header for `.debug_macinfo` sections, but use `Header.getVersion()` in `DWARFDebugMacro::dump()`. Please, fix.
Here @dblaikie . 
However, as I took close a glance on dumping side, I realized passing `StringName` is not necessary at all on one condition that we parse macro/macinfo correctly. 
But while content parsing `macro/macinfo`  sectionwe still have to distinguish.
For parsing, we still need `SectionName` perhaps `Version` ? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086