[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:47
+      // Based on which version we are handling choose appropriate macro forms.
+      if (Macros.Header.getVersion() >= 5)
+        WithColor(OS, HighlightColor::Macro).get() << MacroString(E.Type);
----------------
If we can test the version here - please use the same version test above (for choosing whether to dumpMacroHeader) rather than passing in a string.

(is the version correctly initialized (at least to zero or /something/ not uninitialized) when parsing debug_macinfo/pre-v5 format that doesn't have a header - but that would be necessary for this code already, as well as for removing the use fo the SectionName parameter)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086