[PATCH] D75793: [llvm-objdump] --syms: print 'i' for STT_GNU_IFUNC

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 7 02:10:49 PST 2020


grimar accepted this revision.
grimar added a comment.

I confirm this matches GNU objdump for me.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:44
+    Section: .text
 
   - Name:    func
----------------
Perhaps it is not clear why there is an empty line between locals and globals.
I'd either remove it or add a comment.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1907
+        Indirect = 'i';
+    }
     char Debug = (Type == SymbolRef::ST_Debug || Type == SymbolRef::ST_File)
----------------
nit: you do not need curly bracers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75793/new/

https://reviews.llvm.org/D75793





More information about the llvm-commits mailing list