[PATCH] D74133: [compiler-rt] Build with correct ABI (PR38025)

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

This makes sense to me. I'd prefer @phosek to take another look since he has the most context here, but if he hasn't gone to it in a few days I'd be happy to accept it. Sorry for the delay here.

As for testing on Windows, it'd be fine to commit this and then monitor the Windows bots. (We also have pre-commit testing now, although I don't know if the Windows sanitizer bots are covered by that.)

Do you have commit access, or would you need someone to commit this for you?



================
Comment at: compiler-rt/cmake/Modules/HandleCompilerRT.cmake:62
+    string(REPLACE "builtins" "${name}" LIBRARY_FILE "${LIBRARY_FILE}")
+    cache_compiler_rt_library(FALSE "${name}" "${target}" "${LIBRARY_FILE}")
   endif()
----------------
I don't think it's necessary to cache this one. The string replacement should be pretty cheap to recompute. That would also get you down to just one call to `cache_compiler_rt_library`, at which point you could just inline it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74133/new/

https://reviews.llvm.org/D74133