[PATCH] D75772: [compiler-rt] Set builtins and cxx library for target arch test

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM barring the question about the duplication.



================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:143
+      if(COMPILER_RT_USE_BUILTINS_LIBRARY)
+        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${COMPILER_RT_BUILTINS_LIBRARY}")
+      endif()
----------------
Hmm, I guess `try_compile` doesn't honor `CMAKE_REQUIRED_LIBRARIES`? That's surprising.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:145
+      endif()
+      set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${argstring}")
       try_compile(CAN_TARGET_${arch} ${CMAKE_BINARY_DIR} ${SIMPLE_SOURCE}
----------------
Was it intentional to duplicate this line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75772/new/

https://reviews.llvm.org/D75772