[PATCH] D74819: [DebugInfo] Report unsupported maximum_operations_per_instruction values

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 15:29:41 PST 2020


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:511
+DWARFDebugLine::ParsingState::ParsingState(
+    struct LineTable *LT, uint64_t TableOffset,
+    function_ref<void(Error)> ErrorHandler)
----------------
`struct` can be omitted (and conventional in C++).


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:933
+struct MaxOpsPerInstFixture
+    : public TestWithParam<std::tuple<uint16_t, uint8_t, bool>>,
+      public AdjustAddressFixtureBase {
----------------
`public` can be omitted for `struct`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74819/new/

https://reviews.llvm.org/D74819





More information about the llvm-commits mailing list