[PATCH] D75702: [PowerPC32] Fix the `setcc` inconsistent result type problem

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 11:35:48 PST 2020


sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

1 minor comment but otherwise LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8120
+      Cond = DAG.getSetCC(
+          dl, getSetCCResultType(DAG.getDataLayout(), *DAG.getContext(), OutVT),
+          Cond, DAG.getConstant(1, dl, MVT::i64), ISD::SETUGT);
----------------
The EVT passed in should be `Cond.getValueType()`, or a hard coded `MVT::i64`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75702/new/

https://reviews.llvm.org/D75702





More information about the llvm-commits mailing list