[PATCH] D75616: [AssumeBundles] Add API to query a bundles from a use

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. One nit below.



================
Comment at: llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h:96
 
+struct RetainedKnowledge {
+  Attribute::AttrKind AttrKind = Attribute::None;
----------------
Can you add a short comment here as well please.


================
Comment at: llvm/unittests/Transforms/Utils/KnowledgeRetentionTest.cpp:489
+  RunRandTest(9876789, 100000, -0, 7, 100);
+}
----------------
Tyker wrote:
> jdoerfert wrote:
> > What is the runtime we are expecting here?
> On my computer the average for AssumeQueryAPI.getKnowledgeFromUseInAssume is around 116 ms
> and without the large test the average is below 1ms.
> 
> do you think it is reasonable ? or the test should be reduced in size.
Should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75616/new/

https://reviews.llvm.org/D75616