[PATCH] D75741: AMDGPU: Add check to recompute merge-able instructions

[David Stuttard via Phabricator via llvm-commits]

dstuttard created this revision.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, yaxunl, nhaehnle, wdng, jvesely, kzhuravl, arsenm.
Herald added a project: LLVM.
dstuttard added a comment.
dstuttard added a reviewer: tstellar.

I encountered this issue with a test shader I was looking at. I did manage to create a reproducer, but a different fix to the triviallyDisjoint function meant that it stopped happening.
However, I still think the situation may occur, hence putting this change up for review.

If the consensus is that it is valid, I can try to create a test case for it.


When SILoadStoreOptimizer merges instructions, if an instruction from a
different set of merge-able instructions is moved, this invalidates the yet to be
processed list. This change can detect this situation and forces a re-computation
of the yet to be processed instructions.

This is likely to be a relatively rare occurrence, so the extra overhead of the
computation is negligible.

Change-Id: Ie6d26596fea2af03b0dd5e029d74281079930ad2


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75741

Files:
  llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75741.248720.patch
Type: text/x-patch
Size: 6279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/22e6f77c/attachment.bin>