[PATCH] D75528: [yaml2obj][obj2yaml][test] - Add base tests for relocation addends.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 02:12:32 PST 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/relocation-addend.yaml:1
+## Test how obj2yaml emits relocation addend descriptions.
+## We document that relocation addends are dumped as signed int64 decimal values.
----------------
jhenderson wrote:
> Should we check 0 too? Not sure really, but I suppose it shows that the value 0 is printed, despite being entirely leading zeroes.
Reasonable. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75528/new/

https://reviews.llvm.org/D75528





More information about the llvm-commits mailing list