[PATCH] D75590: [Attributor] IPO across definition boundary of a function marked alwaysinline

[Hideto Ueno via Phabricator via llvm-commits]

uenoku added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1204
+  /// Set of functions that can be inlined
+  SmallPtrSet<Function *, 8> InlineableFunctions;
+
----------------
This and all other helpers should be in `InformationCache`.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1732
+    if (IsFnInterface && (!FnScope || !FnScope->hasExactDefinition())) {
+      if (FnScope && FnScope->hasFnAttribute(Attribute::AlwaysInline)) {
+        return;
----------------
style: no brace for one line if-expr


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75590/new/

https://reviews.llvm.org/D75590