[PATCH] D75725: [MLIR] Ensure that target_link_libraries() always has a keyword.

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgorny, jholewinski.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: nicolasvasilache.
Herald added a reviewer: herhut.
Herald added a reviewer: rriddle.
Herald added a reviewer: antiagainst.
Herald added a project: LLVM.

CMake allows calling target_link_libraries() without a keyword,
but this usage is not preferred when also called with a keyword,
and has surprising behavior.  This patch explicitly specifies a
keyword when using target_link_libraries().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75725

Files:
  mlir/lib/Analysis/CMakeLists.txt
  mlir/lib/Conversion/AffineToStandard/CMakeLists.txt
  mlir/lib/Conversion/GPUToCUDA/CMakeLists.txt
  mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt
  mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt
  mlir/lib/Conversion/GPUToSPIRV/CMakeLists.txt
  mlir/lib/Conversion/GPUToVulkan/CMakeLists.txt
  mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt
  mlir/lib/Conversion/LinalgToSPIRV/CMakeLists.txt
  mlir/lib/Conversion/LoopToStandard/CMakeLists.txt
  mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt
  mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt
  mlir/lib/Conversion/StandardToSPIRV/CMakeLists.txt
  mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt
  mlir/lib/Conversion/VectorToLoops/CMakeLists.txt
  mlir/lib/Dialect/AffineOps/CMakeLists.txt
  mlir/lib/Dialect/CMakeLists.txt
  mlir/lib/Dialect/FxpMathOps/CMakeLists.txt
  mlir/lib/Dialect/GPU/CMakeLists.txt
  mlir/lib/Dialect/LLVMIR/CMakeLists.txt
  mlir/lib/Dialect/Linalg/Analysis/CMakeLists.txt
  mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt
  mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
  mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
  mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt
  mlir/lib/Dialect/LoopOps/CMakeLists.txt
  mlir/lib/Dialect/LoopOps/Transforms/CMakeLists.txt
  mlir/lib/Dialect/OpenMP/CMakeLists.txt
  mlir/lib/Dialect/QuantOps/CMakeLists.txt
  mlir/lib/Dialect/SDBM/CMakeLists.txt
  mlir/lib/Dialect/SPIRV/CMakeLists.txt
  mlir/lib/Dialect/SPIRV/Serialization/CMakeLists.txt
  mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt
  mlir/lib/Dialect/Shape/CMakeLists.txt
  mlir/lib/Dialect/StandardOps/CMakeLists.txt
  mlir/lib/Dialect/VectorOps/CMakeLists.txt
  mlir/lib/ExecutionEngine/CMakeLists.txt
  mlir/lib/IR/CMakeLists.txt
  mlir/lib/Parser/CMakeLists.txt
  mlir/lib/Pass/CMakeLists.txt
  mlir/lib/Quantizer/CMakeLists.txt
  mlir/lib/Support/CMakeLists.txt
  mlir/lib/TableGen/CMakeLists.txt
  mlir/lib/Target/CMakeLists.txt
  mlir/lib/Transforms/CMakeLists.txt
  mlir/lib/Transforms/Utils/CMakeLists.txt
  mlir/lib/Translation/CMakeLists.txt
  mlir/test/lib/IR/CMakeLists.txt
  mlir/test/lib/Pass/CMakeLists.txt
  mlir/test/lib/TestDialect/CMakeLists.txt
  mlir/test/lib/Transforms/CMakeLists.txt
  mlir/tools/mlir-cuda-runner/CMakeLists.txt
  mlir/tools/mlir-opt/CMakeLists.txt
  mlir/tools/mlir-vulkan-runner/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75725.248653.patch
Type: text/x-patch
Size: 23834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/c5f72964/attachment-0001.bin>