[PATCH] D75590: [Attributor] IPO across definition boundary of a function marked alwaysinline

Luofan Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 19:39:19 PST 2020


bbn marked 4 inline comments as done.
bbn added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/alwaysinline.ll:21
+
+; CHECK: Function Attrs: nofree nosync nounwind
+define void @outer1() {
----------------
jdoerfert wrote:
> is this one not readnone?
I think it should be readnone, but I tried opt **without the patch**  with the following example:

```
define void @inner1() alwaysinline {
[...]
}
```

 and the `outer1` function does not have the `readnone` attribute, either.
But when the function does not have `alwayinline` attribute:

```
define void @inner1() {
[....]
}
```

The `outer1` function will have the `readnone` attribute


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75590/new/

https://reviews.llvm.org/D75590





More information about the llvm-commits mailing list