[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:5-7
+# Check that the --debug-vars option correctly aligns the variable display when
+# the source code (printed by the -S option) includes east asian wide
+# characters.
----------------
'##' for comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:10
+# CHECK: 00000000 foo:
+# CHECK-NEXT: ;   return *喵;                                                                 ┠─ 喵 = R0
+# CHECK-NEXT:       0: 00 00 90 e5                  	ldr	r0, [r0]                        ┻
----------------
I think it will, but will this work on Windows (non-UTF8 environment)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720