[PATCH] D75633: [hwasan_symbolize] Make hwasan_symbolize compatible with Android fuzzing out-of-box.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/hwasan/scripts/hwasan_symbolize:204
+    # The Android fuzzing `/data/fuzz` out directory contains executables with
+    # symbols.
+    binary_prefixes.append(os.environ['ANDROID_PRODUCT_OUT'])
----------------
It's not about /data/fuzz specifically. Maybe say that we fallback to $ANDROID_PRODUCT_OUT if the binary can not be found under "symbols" because some targets (ex. fuzzers) install unstripped binaries to the device.

Is this something that should be (could be?) fixed on the Android side? It's the common convention to put unstripped binaries under symbols. Ex. apex generation goes to great lengths to set up paths under symbols/ to match runtime mount path of the apex on device.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75633/new/

https://reviews.llvm.org/D75633