[PATCH] D75713: [llvm-objdump] -d: print `00000000 <foo>:` instead of `00000000 foo:`

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 16:26:29 PST 2020


MaskRay added a comment.

There are a large number of tests which need to be fixed. I'll not add them in the review.

As an example:

  diff --git a/llvm/test/MC/ELF/relax-arith2.s b/llvm/test/MC/ELF/relax-arith2.s
  index ac71a678bc4..9a1153b350d 100644
  --- a/llvm/test/MC/ELF/relax-arith2.s
  +++ b/llvm/test/MC/ELF/relax-arith2.s
  @@ -24,7 +24,7 @@ bar:
   
   // CHECK:      Disassembly of section and:
   // CHECK-EMPTY:
  -// CHECK-NEXT: and:
  +// CHECK-NEXT: <and>:
   // CHECK-NEXT:   0: 66 83 e3 7f                   andw $127, %bx
   // CHECK-NEXT:   4: 66 83 24 25 00 00 00 00 00    andw $0, 0
   // CHECK-NEXT:   d: 83 e3 01                      andl $1, %ebx


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75713/new/

https://reviews.llvm.org/D75713





More information about the llvm-commits mailing list