[PATCH] D75408: [ConstantFolding] Make sure constants are fully folded

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 12:40:05 PST 2020


nikic updated this revision to Diff 248570.
nikic retitled this revision from "[ConstantFolding] Make sure GEPs are fully folded" to "[ConstantFolding] Make sure constants are fully folded".
nikic added a comment.

Rerun constant folding in ConstantFoldInstruction and ConstantFoldConstant to make sure the result is fully folded.

I'm wondering whether I should push this further back into APIs like ConstantFoldInstOperands, which are also public. Might be a bit ugly implementation-wise, and we'll lose FoldedOps along the way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75408/new/

https://reviews.llvm.org/D75408

Files:
  lib/Analysis/ConstantFolding.cpp
  test/Analysis/ConstantFolding/gep-zeroinit-vector.ll
  test/Transforms/ConstProp/bitcast.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75408.248570.patch
Type: text/x-patch
Size: 4589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200305/4cfd2efb/attachment.bin>


More information about the llvm-commits mailing list