[PATCH] D75699: [mlir] [VectorOps] Merge VectorReduction/VectorReductionV2 into one Op

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 10:23:11 PST 2020


aartbik created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.
aartbik added reviewers: andydavis1, ftynse, rriddle.
aartbik edited the summary of this revision.

Paying off some technical debt in VectorOps, where I introduced a special
op for a fused accumulator into reduction to avoid some issues around
printing and parsing an optional accumulator. This CL merges the two
into one op again and does things the right way (still would be nice
to have "assemblyFormat" for optional operands though....).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75699

Files:
  mlir/include/mlir/Dialect/VectorOps/VectorOps.td
  mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
  mlir/lib/Dialect/VectorOps/VectorOps.cpp
  mlir/lib/Dialect/VectorOps/VectorTransforms.cpp
  mlir/test/Dialect/VectorOps/invalid.mlir
  mlir/test/Dialect/VectorOps/ops.mlir
  mlir/test/Dialect/VectorOps/vector-contract-transforms.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75699.248535.patch
Type: text/x-patch
Size: 21546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200305/249b67ff/attachment-0001.bin>


More information about the llvm-commits mailing list