[PATCH] D75528: [yaml2obj][obj2yaml][test] - Add base tests for relocation addends.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 09:18:20 PST 2020


MaskRay added a comment.

I think a signed integer representation may look better in most situations. r_addend is usually additive, e.g. S + A, G + A. Due to PC-offset bias, an r_addend on x86-32/x86-64/ARM/MIPS is usually negative (well, x86-32/ARM/MIPS use REL instead of RELA), so we may see a lot of `0xFFFFFFFC`. `-4` is likely prettier.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75528/new/

https://reviews.llvm.org/D75528





More information about the llvm-commits mailing list