[PATCH] D73176: [ARM] Fix dropped dollar sign from symbols in branch targets

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 06:35:42 PST 2020


pratlucas marked 2 inline comments as done.
pratlucas added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6061
+          (AdjacentToken.is(AsmToken::Identifier) ||
+           AdjacentToken.is(AsmToken::String) ||
+           AdjacentToken.is(AsmToken::Integer));
----------------
efriedma wrote:
> AsmToken::String?  I don't see any testcase for that.
I removed `AsmToken::String` from the identifier handling in D75111 but forgot to update this condition. Sorry about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73176/new/

https://reviews.llvm.org/D73176





More information about the llvm-commits mailing list