[PATCH] D75608: [lib/ObjectYAML] - Make `ELFYAML::Relocation::Offset` optional.

Thu Mar 5 06:35:41 PST 2020

grimar marked an inline comment as done.
grimar added a comment.

In D75608#1907201 <https://reviews.llvm.org/D75608#1907201>, @jhenderson wrote:

> I don't have any strong opinion on this. I personally would be slightly confused not seing an Offset printed by obj2yaml for one of the relocations, but I'm okay with it if you prefer that.

I think that one of the reason why we consistently see overloaded YAMLs on reviews is that because obj2yaml seems prints more data than it can.

================
Comment at: llvm/test/Object/X86/yaml-elf-x86-rel-broken.yaml:4

+## TODO: Remove this test.
+
----------------
jhenderson wrote:
> Maybe worth doing this first?
D75679 removes this file.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75608/new/

https://reviews.llvm.org/D75608