[PATCH] D75527: [yaml2obj] - Add `ELFYAML::YAMLInt` to fix how we parse a relocation `Addend` key.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 02:14:09 PST 2020


jhenderson added a comment.

My inclination is that yaml2obj should support both signed and unsigned variants of both hex and decimal numbers, if feasible. I think obj2yaml should print as unsigned hex numbers, since that is what is displayed by tools such as llvm-readelf. In other words, an addend of -4 would be printed by obj2yaml as "0xFFFFFFFFFFFFFFFC" in a 64-bit object, but could be specified as "-4", "-0x0000000000000004", or "0xFFFFFFFFFFFFFFFC" for yaml2obj.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75527/new/

https://reviews.llvm.org/D75527





More information about the llvm-commits mailing list