[PATCH] D73059: [IndVarSimplify] Extend previous special case for load use instruction to any narrow type loop variant to avoid extra trunc instruction

Ehsan Amiri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 21:14:24 PST 2020


amehsan accepted this revision.
amehsan added a comment.
This revision is now accepted and ready to land.

@sanjoy @efriedma @sebpop @reames @az @javed.absar

Is there any concern about this patch? We have reviewed this internally and it looks good to me. It has been also tested extensively. The condition on the load instruction does not seem to have any role in correctness of the transformations and seems to be a completely arbitrary condition.  I accept the patch for now, but I will wait and prefer to hear from one of the other reviewers before committing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73059/new/

https://reviews.llvm.org/D73059





More information about the llvm-commits mailing list