[PATCH] D75616: [AssumeBundles] Add API to query a bundles from a use

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/IR/Instructions.cpp:387
 
+CallBase::BundleOpInfo &CallBase::getBundleOpInfoForOperand(unsigned OpIdx) {
+  if (bundle_op_info_end() - bundle_op_info_begin() < 8) {
----------------
Please explain this in a comment at the beginning of the function. Also comment the magic constants.
Add text to asserts please.


================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:291
+  return Result;
+}
+
----------------
Is this more for testing or do you expect another use case?


================
Comment at: llvm/unittests/Transforms/Utils/KnowledgeRetentionTest.cpp:489
+  RunRandTest(9876789, 100000, -0, 7, 100);
+}
----------------
What is the runtime we are expecting here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75616/new/

https://reviews.llvm.org/D75616