[PATCH] D75498: [llvm-objdump] Add option to sort symbols during disassembly

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 16:20:23 PST 2020


MaskRay added a comment.

In D75498#1906052 <https://reviews.llvm.org/D75498#1906052>, @stephenneuendorffer wrote:

> > As I commented at https://reviews.llvm.org/D75498#1904244 , `some other linker disassembles symbols in alphabetical order` does not match what I have observed with GNU ld, gold and lld. Are you using a different linker or am I missing something?
>
> You're not missing anything.  The linker in question is not an open source linker.


Shouldn't that linker be fixed instead? It is usually a simple data structure replacement... For example, `unordered_map` -> `begin`.

Sorry that I will make some pushback here. A non-deterministic symbol order also affects other tools like readelf/nm. Fixing the linker is likely the simplest way to make every binary manipulation tool happy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75498/new/

https://reviews.llvm.org/D75498





More information about the llvm-commits mailing list