[PATCH] D75120: [ValueLattice] Add new state for undef constants. (WIP)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 14:38:02 PST 2020


fhahn added a comment.

In D75120#1893937 <https://reviews.llvm.org/D75120#1893937>, @efriedma wrote:

> If you don't have all the relevant states represented in the ValueLattice, where are you storing the "possibly undef" bit?  I think having all the states in the ValueLattice is simpler, at least conceptually.


Thanks Eli (and sorry for the late response, I somehow missed your response).

I *think* the callers of the mergeIn functions should the information, but I agree it would be much better to model it explicitly. I'll put up a patch soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75120/new/

https://reviews.llvm.org/D75120





More information about the llvm-commits mailing list