[PATCH] D75586: [MLIR][Affine][NFC] Remove obsolete and ambiguous definitions

[Frank Laub via Phabricator via llvm-commits]

flaub marked an inline comment as done.
flaub added a comment.

I tried to use this from outside of MLIR core and it ended up not possible to even call the `getFlattendAffineExprs` that doesn't take a 3rd argument due to that being ambiguous with the one defined in `AffineStructures`.



================
Comment at: mlir/include/mlir/IR/AffineExpr.h:82
 
-  template <typename U> bool isa() const;
-  template <typename U> U dyn_cast() const;
-  template <typename U> U dyn_cast_or_null() const;
-  template <typename U> U cast() const;
+  template <typename U>
+  bool isa() const;
----------------
rriddle wrote:
> Note, if you use git-clang-format it should only format the changes that you've made without touching existing code.
Thanks! I didn't know about this and I'll try to use this in my workflow from now on :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75586/new/

https://reviews.llvm.org/D75586