[PATCH] D75484: [mlir][spirv] Add get() method to TargetEnvAttr taking raw values

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 10:39:42 PST 2020


mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h:58
+                           DictionaryAttr limits);
   static TargetEnvAttr get(IntegerAttr version, ArrayAttr extensions,
                            ArrayAttr capabilities, DictionaryAttr limits);
----------------
Can we deprecate this one. I dont see a point of that anymore..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75484/new/

https://reviews.llvm.org/D75484





More information about the llvm-commits mailing list