[PATCH] D75619: [mlir] LLVM dialect: move ensureDistinctSuccessors out of std->LLVM conversion

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 10:39:35 PST 2020


rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/Transforms/Legalize.h:29
+/// be translated to LLVM IR.
+std::unique_ptr<Pass> createLegalizePass();
+
----------------
Can we give this a better name? `Legalize` seems general, and doesn't really hint that this is just for exporting to LLVMIR. `LegalizeForExport` seems slightly better, but I'm sure there is a better suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75619/new/

https://reviews.llvm.org/D75619





More information about the llvm-commits mailing list