[PATCH] D75531: [mlir][vulkan-runner] Add basic timing for compute pipeline

Wed Mar 4 09:33:00 PST 2020

mehdi_amini added inline comments.

================
Comment at: mlir/tools/mlir-vulkan-runner/VulkanRuntime.cpp:17
+#include <chrono>
+#include <iostream>
+
----------------
antiagainst wrote:
> rriddle wrote:
> > LLVM forbids the use of iostream.
> > 
> > https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden
> Changed to llvm::outs. I saw we are using iostream already in RunnerUtils.h and cblas_interface.h so wanted to be consistent there. Should those be fixed?
Isn’t cblas_interface for generated code intended to be used a runtime for generated code, including outside of a JIT environment?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75531/new/

https://reviews.llvm.org/D75531