[PATCH] D75610: [mlir][ods] Improve integer signedness modelling

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added a reviewer: rriddle.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added 1 blocking reviewer(s): rriddle.
Herald added a project: LLVM.
antiagainst added a child revision: D75611: [mlir][spirv] Support integer signedness.

A previous commit added support for integer signedness in C++
IntegerType. This change introduces ODS definitions for
integer types and integer (element) attributes w.r.t. signedness.

This commit also updates various existing definitions' descriptions
to mention signless where suitable to make it more clear.

Positive and non-negative integer attributes are removed to avoid
the explosion of subclasses. Instead, one should use more atmoic
constraints together with Confined to model that. For example,
`Confined<..., [IntPositive]>`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75610

Files:
  mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
  mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
  mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
  mlir/include/mlir/IR/OpBase.td
  mlir/test/Dialect/LLVMIR/global.mlir
  mlir/test/Dialect/Loops/invalid.mlir
  mlir/test/Dialect/SPIRV/ops.mlir
  mlir/test/IR/attribute.mlir
  mlir/test/IR/invalid-ops.mlir
  mlir/test/lib/TestDialect/TestOps.td
  mlir/test/mlir-tblgen/predicate.td
  mlir/test/mlir-tblgen/types.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75610.248174.patch
Type: text/x-patch
Size: 41292 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200304/7fd4bada/attachment.bin>