[PATCH] D73501: [SCEV] rewriteLoopExitValues(): even if have hard uses, still rewrite if cheap (PR44668)

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 05:39:15 PST 2020


samparker added a comment.

Hi,
Did you get performance numbers for these patches? We track the performance of our (Arm) open source DSP library and the cost model fixes were generally a notable improvement, so many thanks for that! But the final patch for rewriting exit values has generally been bad, especially considering the gains from the modelling improvements. I need to look into it further, but on my current test case I'm seeing +30% increase in stack accesses with a similar decrease in performance. I'm just wondering if you observed any negative effects yourself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73501/new/

https://reviews.llvm.org/D73501





More information about the llvm-commits mailing list